summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRyan Beisner <ryan.beisner@canonical.com>2019-02-08 15:52:13 -0600
committerRyan Beisner <ryan.beisner@canonical.com>2019-02-08 15:52:20 -0600
commit2996db663ffe78ef4754233f9ab565cc92551c9c (patch)
treee51638916e7411f09956f07a4d551e07cad1ecf8
parent0cc0325d85a1f83de7c419c2681bbd1d81283f07 (diff)
downloadcharm-nova-lxd-2996db663ffe78ef4754233f9ab565cc92551c9c.zip
charm-nova-lxd-2996db663ffe78ef4754233f9ab565cc92551c9c.tar.gz
charm-nova-lxd-2996db663ffe78ef4754233f9ab565cc92551c9c.tar.bz2
Update pre-install hooks to fail on error
The pre-install operations may fail, yet that failure is not elevated to the user. This masks the failure and makes early package install issues difficult to troubleshoot. If the basic pre-install script fails, the charm should not proceed to later hooks as the requirements may not be met. Hashbangs for bash should specify -e (errexit) on all of the pre-install bash scripts. Change-Id: I6178e2cb6665b7a4bdbe66a63b29616067932352 Closes-bug: #1815243 Partial-bug: #1815231
-rwxr-xr-xhooks/install2
1 files changed, 1 insertions, 1 deletions
diff --git a/hooks/install b/hooks/install
index 15dcbe1..26d9b25 100755
--- a/hooks/install
+++ b/hooks/install
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/bash -e
# Wrapper to deal with newer Ubuntu versions that don't have py2 installed
# by default.

This mirror site include all the OpenStack related repositories under: openstack, openstack-dev and openstack-infra.

NOTE: All repositories are updated every one hour.

Usage

For Git Clone
 git clone http://git.trystack.cn/openstack/nova.git 
For DevStack

Add GIT_BASE, NOVNC_REPO and SPICE_REPO variables to local.conf file.

[[local|localrc]]

# use TryStack git mirror
GIT_BASE=http://git.trystack.cn
NOVNC_REPO=http://git.trystack.cn/kanaka/noVNC.git
SPICE_REPO=http://git.trystack.cn/git/spice/spice-html5.git